From f14a5dc2c0523b62273da180aaaa438f3a588346 Mon Sep 17 00:00:00 2001
From: Sascha <saschab42@gmail.com>
Date: Thu, 30 Oct 2025 16:31:46 +0100
Subject: [PATCH] sonarqube fixes regarding unnecessary tabindexes and roles

sonarqube fixes
---
 src/components/sections/AboutSection.tsx          | 1 -
 src/components/sections/CertificationsSection.tsx | 3 +--
 src/components/sections/ContactSection.tsx        | 2 +-
 src/components/sections/HeroSection.tsx           | 3 +--
 src/components/sections/ProjectsSection.tsx       | 3 ---
 src/components/sections/SkillsSection.tsx         | 2 --
 src/scss/sections/contact-section.scss            | 1 -
 7 files changed, 3 insertions(+), 12 deletions(-)

diff --git a/src/components/sections/AboutSection.tsx b/src/components/sections/AboutSection.tsx
index d6b96d7..b4684f5 100644
--- a/src/components/sections/AboutSection.tsx
+++ b/src/components/sections/AboutSection.tsx
@@ -112,7 +112,6 @@ export default function AboutSection(props: AboutSectionProps = {}) {
                 <article
                   key={index}
                   className={`about-section__feature-card about-section__feature-card--${card.colorClass}`}
-                  tabIndex={0}
                   role="group"
                   aria-labelledby={`feature-${index}-title`}
                   aria-describedby={`feature-${index}-description`}
diff --git a/src/components/sections/CertificationsSection.tsx b/src/components/sections/CertificationsSection.tsx
index 4fab98b..4911349 100644
--- a/src/components/sections/CertificationsSection.tsx
+++ b/src/components/sections/CertificationsSection.tsx
@@ -51,7 +51,7 @@ export default function CertificationsSection(props: CertificationsSectionProps
 
   // Sort certifications by year in descending order (newest first)
   const sortedCertifications = [...certifications].sort((a, b) => {
-    return parseInt(b.year) - parseInt(a.year);
+    return Number.parseInt(b.year) - Number.parseInt(a.year);
   });
 
   return (
@@ -92,7 +92,6 @@ export default function CertificationsSection(props: CertificationsSectionProps
             <article
               key={index}
               className="certifications-section__card"
-              tabIndex={0}
               role="group"
               aria-labelledby={`cert-${index}-title`}
               aria-describedby={`cert-${index}-details`}
diff --git a/src/components/sections/ContactSection.tsx b/src/components/sections/ContactSection.tsx
index 07d4b26..5fccf46 100644
--- a/src/components/sections/ContactSection.tsx
+++ b/src/components/sections/ContactSection.tsx
@@ -137,7 +137,7 @@ export default function ContactSection(props: ContactSectionProps = {}) {
           </div>
 
           {/* Contact Info Sidebar */}
-          <aside className="contact-section__sidebar" role="complementary" aria-labelledby="info-heading">
+          <aside className="contact-section__sidebar" aria-labelledby="info-heading">
             <div className="contact-section__info-card">
               <h3 id="info-heading" className="sr-only">Contact Information</h3>
 
diff --git a/src/components/sections/HeroSection.tsx b/src/components/sections/HeroSection.tsx
index 675ae69..62fe006 100644
--- a/src/components/sections/HeroSection.tsx
+++ b/src/components/sections/HeroSection.tsx
@@ -143,13 +143,12 @@ export default function HeroSection(props: HeroSectionProps = {}) {
           This will download my current resume in PDF format
         </div>
 
-        <aside className="hero-section__stats" role="complementary" aria-labelledby="stats-heading">
+        <aside className="hero-section__stats" aria-labelledby="stats-heading">
           <h2 id="stats-heading" className="sr-only">Professional Statistics</h2>
           {statItems.map((item, index) => (
             <div
               key={item.label}
               className={`hero-section__stat-item hero-section__stat-item--${index + 1}`}
-              role="group"
               aria-labelledby={`stat-${index}-label`}
             >
               <span
diff --git a/src/components/sections/ProjectsSection.tsx b/src/components/sections/ProjectsSection.tsx
index e9e3124..de7ae8c 100644
--- a/src/components/sections/ProjectsSection.tsx
+++ b/src/components/sections/ProjectsSection.tsx
@@ -232,9 +232,6 @@ export default function ProjectsSection(props: ProjectsSectionProps = {}) {
                 key={project.id}
                 className={`projects-section__card ${isActive ? 'projects-section__card--active' : ''}`}
                 ref={(el) => { cardRefs.current[cardIndex] = el; }}
-                tabIndex={0}
-                role="gridcell"
-                aria-expanded={isActive}
                 aria-describedby={`project-${project.id}-description project-${project.id}-metadata`}
                 aria-label={`Project card: ${project.title}. ${cardIndex + 1} of ${projects.length}`}
                 onKeyDown={(e) => handleCardKeyDown(e, cardIndex)}
diff --git a/src/components/sections/SkillsSection.tsx b/src/components/sections/SkillsSection.tsx
index 9f16c2f..680f493 100644
--- a/src/components/sections/SkillsSection.tsx
+++ b/src/components/sections/SkillsSection.tsx
@@ -125,7 +125,6 @@ export default function SkillsSection(props: SkillsSectionProps = {}) {
                 className={`skills-section__category skills-section__category--${colorClass}`}
                 role="group"
                 aria-labelledby={`category-${categoryIndex}-title`}
-                tabIndex={0}
               >
                 <header className="skills-section__category-header">
                   <h3
@@ -152,7 +151,6 @@ export default function SkillsSection(props: SkillsSectionProps = {}) {
                         key={skillItem.skill}
                         className="skills-section__skill-item"
                         role="listitem"
-                        tabIndex={0}
                         aria-label={`${skillItem.skill}: ${displayLevel} level`}
                       >
                         <div className="skills-section__skill-header">
diff --git a/src/scss/sections/contact-section.scss b/src/scss/sections/contact-section.scss
index da926d0..6602cda 100644
--- a/src/scss/sections/contact-section.scss
+++ b/src/scss/sections/contact-section.scss
@@ -115,7 +115,6 @@
   &__social-title {
     font-size: 1.125rem;
     font-weight: 600;
-    margin-bottom: 1rem;
     color: var(--color-text);
     margin-bottom: var(--card-padding-sm);
   }